Skip to content

Conversation

@midigofrank
Copy link
Collaborator

Description

This PR [adds/changes/fixes]... (A description of your work goes here.)

Closes #4098
Closes #4060 
Closes #4058
Closes #3870
Closes #3726
Closes #3481

Validation steps

  1. (How can a reviewer validate your work?)

Additional notes for the reviewer

https://hexdocs.pm/tesla/v1-macro-migration.html

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

Pre-submission checklist

  • I have performed a self-review of my code.
  • I have implemented and tested all related authorization policies. (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

@github-project-automation github-project-automation bot moved this to New Issues in v2 Jan 9, 2026
midigofrank and others added 4 commits January 9, 2026 09:17
Remove deprecated `use Tesla` and `plug` macros in favor of explicit
Tesla.client() calls with middleware configuration. This migration:

- Removes all `use Tesla` declarations
- Converts `plug` macros to explicit middleware lists
- Adds adapter helper functions for test compatibility
- Updates all HTTP method calls to use Tesla.* prefix

All Tesla clients now use explicit client building with middleware
and adapter configuration via Application.get_env.

Fixes deprecation warnings from Tesla 1.15+ upgrade.
Fix sobelow warning
Fix dialyzer error from storybook
Don't log low threshold warnings on CI.
@stuartc
Copy link
Member

stuartc commented Jan 16, 2026

@taylordowns2000 I've removed the .sobelow-skips file. We prefer to make inline skips and justify that specific place with a comment.

@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 87.17949% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.30%. Comparing base (6cb4def) to head (af0c491).
⚠️ Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
lib/lightning/version_control/github_client.ex 79.16% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4294      +/-   ##
==========================================
- Coverage   89.35%   89.30%   -0.05%     
==========================================
  Files         425      425              
  Lines       19913    19923      +10     
==========================================
- Hits        17793    17792       -1     
- Misses       2120     2131      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stuartc stuartc marked this pull request as ready for review January 16, 2026 13:47
@stuartc stuartc merged commit 4facfba into main Jan 16, 2026
6 of 8 checks passed
@stuartc stuartc deleted the bump-deps branch January 16, 2026 14:10
@github-project-automation github-project-automation bot moved this from New Issues to Done in v2 Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants